Hi @Asif-git03. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Hi Team,

Request you to please review the PR, since the DCO signoff: yes

Hi Team,

Could you please check on this PR once

Hi Team,

Request you to please review the PR, since the DCO signoff: yes

@Asif-git03 trust-manager is a community project and maintainers/reviewers all have day-time jobs. So please don't expect reviews when you request it. And no point "spamming". 😓

I am personally not in favor of your proposed changes. What is the use case? And how is it related to DRY? It definitely increases complexity by adding a second layer of templating. Trying to understand what your goal is, but no luck so far.....

@Asif-git03 trust-manager is a community project and maintainers/reviewers all have day-time jobs. So please don't expect reviews when you request it. And no point "spamming". 😓

I am personally not in favor of your proposed changes. What is the use case? And how is it related to DRY? It definitely increases complexity by adding a second layer of templating. Trying to understand what your goal is, but no luck so far.....

Hello Erik (@erikgb),
I am Asif's team lead on this item. From what I see, the task of adding some DRY (Don't Repeat Yourself) support has been misunderstood.
He will rollback his changes and come back with a proper implementation...

Our intent is that, because we are using cert-manager and trust-manager into an umbrella chart, we want in our chart to default the app.trust.namespace and app.webhook.tls.approverPolicy.certManagerNamespace parameters to "{{ .Release.Namespace }}" so all the namespaces involved are in sync whatever the value of the --namespace option is. In order to do so, we need to introduce the tpl function where these 2 parameters are used in the templates.

Hi Erik,

I have reverted the changes which were earlier done, and have made new changes which can avoid repetition of the same parameter multiple times

Ok, I understand the use case better now. Thanks for explaining @Ceddaerrix! I am personally not a big fan of the proposed changes, but we will discuss this in the maintainer team.

@Asif-git03 Can you please update the PR title and description, and revert irrelevant changes in the PR diff?

Sure Eric, how do you want it to be?(PR title and description) :)

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Ok, I understand the use case better now. Thanks for explaining @Ceddaerrix! I am personally not a big fan of the proposed changes, but we will discuss this in the maintainer team.

Hello Erik (@erikgb),

Any estimate on when we could have a final decision on the current matter?
Thank you

Hi @Ceddaerrix @Asif-git03, sorry for the delay on this. All projects under the cert-manager org are community projects, and we all have other daytime jobs. Att'ing people to get attention is not the way to make progress on issues and PRs. 😃 Instead you should join our daily stand-ups and/or bi-weekly meetings to discuss the matter: https://cert-manager.io/docs/contributing/.

We discussed this PR in today's stand-up and decided that we don't like the approach taken here. Adding template support for Helm values doesn't seem like a good idea. It adds even more complexity to charts and also another layer of templating which may open security holes.

AFAIK your use case is described by @Ceddaerrix in #496 (comment):

Our intent is that, because we are using cert-manager and trust-manager into an umbrella chart, we want in our chart to default the app.trust.namespace and app.webhook.tls.approverPolicy.certManagerNamespace parameters to "{{ .Release.Namespace }}" so all the namespaces involved are in sync whatever the value of the --namespace option is. In order to do so, we need to introduce the tpl function where these 2 parameters are used in the templates.

One way to solve this could be using Helm global values: https://helm.sh/docs/chart_template_guide/subcharts_and_globals/. We are more likely to accept PRs adding support for global values into our charts. As long as the change is non-breaking.

I am going to close this PR now, as it is not going to be merged with the proposed changeset.

/close

@erikgb: Closed this PR.

Hi @Ceddaerrix @Asif-git03, sorry for the delay on this. All projects under the cert-manager org are community projects, and we all have other daytime jobs. Att'ing people to get attention is not the way to make progress on issues and PRs. 😃 Instead you should join our daily stand-ups and/or bi-weekly meetings to discuss the matter: https://cert-manager.io/docs/contributing/.

We discussed this PR in today's stand-up and decided that we don't like the approach taken here. Adding template support for Helm values doesn't seem like a good idea. It adds even more complexity to charts and also another layer of templating which may open security holes.

AFAIK your use case is described by @Ceddaerrix in #496 (comment):

Our intent is that, because we are using cert-manager and trust-manager into an umbrella chart, we want in our chart to default the app.trust.namespace and app.webhook.tls.approverPolicy.certManagerNamespace parameters to "{{ .Release.Namespace }}" so all the namespaces involved are in sync whatever the value of the --namespace option is. In order to do so, we need to introduce the tpl function where these 2 parameters are used in the templates.

One way to solve this could be using Helm global values: https://helm.sh/docs/chart_template_guide/subcharts_and_globals/. We are more likely to accept PRs adding support for global values into our charts. As long as the change is non-breaking.

I am going to close this PR now, as it is not going to be merged with the proposed changeset.

/close

Hello Erik (@erikgb),

Thank you for taking the time to reply.
Even though I do not that the use of tpl is a breaking change (as it allows to take the string value of another parameter), we will look into use of the Helm global values...